Open
Conversation
dogezen
reviewed
May 15, 2024
index.html
Outdated
| <a href="/" class="logo">Thomas Jensen</a> | ||
| <a href="/" class="logo-heb">תומס ינסן</a> | ||
| </div> | ||
| <div class="links"> |
There was a problem hiding this comment.
class names can be more specific: header-links rather than just links
index.html
Outdated
| </header> | ||
| <main> | ||
| <div class="splash"> | ||
| <br /> |
There was a problem hiding this comment.
maybe use a margin instead of br? a
with a specific class that adds a margin as required
index.html
Outdated
| </section> | ||
| </div> | ||
| <div id="about-me"></div> | ||
| <div class="about-me"> |
There was a problem hiding this comment.
this should not be a div, but rather a section
index.html
Outdated
| <div class="about-me"> | ||
| <br /> | ||
| <h1>About Me</h1> | ||
| <section> |
There was a problem hiding this comment.
this should just be a div because we are inside the section
style.css
Outdated
| font-family:; | ||
| } | ||
|
|
||
| header .logo { |
There was a problem hiding this comment.
no need to repeat header .logo you could just have .logo although a better name would be .header-logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.